-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement CreateOrUpdateStream function #1395
Conversation
Thanks you for creating the PR! The difference between creating streams and consumers is server side - for consumers, there used to be a single API for both creating and updating a consumer, thus it was a single operation on the client (that will change with the upcoming server release though, and we will be adding That said, I am not strongly against adding |
Thanks :) I would be happy to help to implement this function in other clients |
this feature is going to be a very very useful feature and will use it definitely. |
Cool feature. Bravo @samanebi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature looks good and we will add it! I only have a few suggestions.
…ge TestCreateOrUpdate_CreateStream and TestCreateOrUpdate_UpdateStream
All requested changes has been applied |
I am wondering when do you plan on merging this PR ? |
Is there any update on this? I have done the suggested changes and also re requested review to @piotrpio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@samanebi Sorry for the delay, looks good! It'll be a part of the next release. |
After using JetStream on a private project I felt the need for CreateOrUpdateStream like CreateOrUpdateConsumer. This function updates if stream exists, otherwise it creates the stream.